Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to edit actions #603

Closed
17 tasks done
sds100 opened this issue Feb 21, 2021 · 3 comments
Closed
17 tasks done

ability to edit actions #603

sds100 opened this issue Feb 21, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@sds100
Copy link
Collaborator

sds100 commented Feb 21, 2021

  • redesign choose action screen. Don't have tabs because there are very many now. Show a grid/list of buttons that list all the types of actions to choose from in a fragment and then show the most appropriate screen to configure it. E.g if it is a Text action then show the dialog to set the text. If it is an app action then show a dialog with the list of apps
  • All actions should be shown in the grid. I.e "Open app, toggle wifi, enable wifi, etc" and not just a list of the type of apps.
  • have headers for different categories
  • search button
  • remove key action type
  • Design should be a more compact version of the Android 12 quick settings tiles.
  • The secondary text should show whether root (and or shizuku) is required.
  • Unsupported actions should also be shown but greyed out and the secondary text should explain why.
  • ensure warnings and explanations for all actions are shown at some point
  • redesign constraints screen.
    • use grid
  • add button on action list item to edit it. See picture in constraints should be tied to the action and not the whole mapping #644. The Edit button should show two buttons at top called "Edit action and Replace action" and then a header below with "Options" and then a list of options.
  • test editing intents

Developer TODO (don't remove)

  • create new branch. put issue number at start of name
  • write tests before working on feature. put issue number in comment
  • update documentation (edit actions screen, choose actions screen)
  • delete branch
@sds100 sds100 added the enhancement New feature or request label Feb 21, 2021
@sds100 sds100 self-assigned this Feb 21, 2021
@sds100
Copy link
Collaborator Author

sds100 commented Jul 27, 2021

implemented

@sds100
Copy link
Collaborator Author

sds100 commented Aug 29, 2021

update docs to show edit button instead of 3 dots

@sds100
Copy link
Collaborator Author

sds100 commented Aug 29, 2021

done

@sds100 sds100 closed this as completed Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant