Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): configurable key-cap hints 🐵 #9829

Merged
merged 12 commits into from
Nov 6, 2023

Conversation

jahorton
Copy link
Contributor

@jahorton jahorton commented Oct 23, 2023

Fixes #5079.

Fully integrates the new 'hint' property supported for touch layouts within KeymanWeb.

Note that a few styling differences were necessary to accomplish this...

  • The text-content for the hint is now applied directly to the 'kmw-key-popup-icon' element, rather than specified in CSS for its :before pseudo-element. Kinda necessary, since the hint is no longer statically defined.
  • The bold styling for the font has been dropped except when the classic \u2022 dot is used.
  • Whatever the source for the hint's text is, its customized font (if defined) is used for styling. In the absence of that, the keyboard's specified font for text is applied to the hint.

Some example screenshots from some test-oriented keyboards I'm developing:

(defaultHint: 'flick')

image

(each key has a custom hint value)

image

And, of course, we mustn't break the classic:

(a pre-existing keyboard defining neither hint nor defaultHint)

image

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 23, 2023

User Test Results

Test specification and instructions

User tests are not required

@jahorton jahorton force-pushed the feat/web/custom-key-hints branch from 10a57ac to 5eddecd Compare October 24, 2023 01:31
@jahorton jahorton changed the base branch from feat/web/gesture-preview-host to fix/web/state-change-source-rewrite October 24, 2023 01:32
@jahorton jahorton marked this pull request as ready for review October 24, 2023 02:15
@jahorton jahorton requested a review from mcdurdin as a code owner October 24, 2023 02:15
@mcdurdin mcdurdin modified the milestones: A17S24, A17S25 Oct 27, 2023
@jahorton jahorton linked an issue Oct 30, 2023 that may be closed by this pull request
Base automatically changed from fix/web/state-change-source-rewrite to feature-gestures November 6, 2023 01:27
@jahorton jahorton merged commit 1bfe774 into feature-gestures Nov 6, 2023
@jahorton jahorton deleted the feat/web/custom-key-hints branch November 6, 2023 01:27
@jahorton jahorton mentioned this pull request Dec 12, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec(developer,web): support "hint" property for touch layouts 🐵
2 participants