-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(developer): kmc analyze osk-char-use 🗜 #8723
Conversation
Relates to keymanapp/keyboards#2172. Adds an analysis module to kmc which initially analyses one or more .kvks or .keyman-touch-layout files, extracting the de-duped and sorted set of key cap strings from those files and printing them, in text, markdown, or json format.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
f38fa72
to
6094457
Compare
In order to match existing behaviour with the legacy KeymanWeb compiler, we should use quoted numbers for row ids. This behaviour can probably be changed over to the new model in the future, but for now this prevents unit tests from causing us grief.
Tidies up silent vs quiet vs verbose by adding logLevel as an option. * Notes that we need to consolidate all the various CompilerOptions interfaces before they get too much further out of hand. * Cleans up a couple of other minor TODO items.
* Also adds info messages for scanning.
Preliminary comment: at one point, we had a regression-test system set up for KMW. (Link = its readme.) Of particular note:
There is (?) / was (?) an existing
It's clear that this new module isn't (yet) equal to the older |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like a lot of log-message stuff got thrown into here without being mentioned... enough so that it would've been nice if it were its own PR. Likely due to the info
level being utilized here, making things noisy?
LGTM though.
All the existing command line tools are being deprecated. i.e. So, yes, |
In hindsight, yeah ... probably. The main reason for the log-message tweaks being included here was we needed a 'silent' mode for logging when emitting to console, so that |
Relates to keymanapp/keyboards#2172.
Adds an analysis module to kmc which initially analyses one or more .kvks or .keyman-touch-layout files, extracting the de-duped and sorted set of key cap strings from those files and printing them, in text, markdown, or json format.
I have created a TODO list in #8969, but none of the items in the list should block merge into kmc-kmw. All TODO items in the source are listed in #8969.
@keymanapp-test-bot skip