fix(common/models): reconnects unit tests for worker-internal submodules 🎡 #7215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
changed the title
jahorton
commented
Sep 6, 2022
Comment on lines
24
to
34
| it('handles heavily-punctuated English text', function() { | ||
| // This test case brought to you by http://unicode.org/reports/tr29/#Word_Boundaries, Figure 1. | ||
| let breaks = breakWords( | ||
| `The quick ("brown") fox can't jump 32.3 feet, right?` | ||
| ); | ||
| let words = breaks.map(span => span.text); | ||
| assert.deepEqual(words, [ | ||
| 'The', 'quick', '(', '"', 'brown', '"', ')', 'fox', "can't", | ||
| 'jump', '32.3', 'feet', ',', 'right', '?' | ||
| ]); | ||
| }); |
There was a problem hiding this comment.
I added this one locally while diagnosing #6900, since determining whether or not the wordbreaker might be partially at fault for the mishandling of quotation marks helped me to narrow down the search space.
mcdurdin
approved these changes
Sep 7, 2022
|
Changes in this pull request will be available for download in Keyman version 16.0.58-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, it turns out that during the big 🎡 chain in which we reorganized much of the Web-related part of the repo, there were a few sets of unit tests that never got reconnected. Heck, even I missed 'em at the time.
Ran into this while investigating the wordbreaker via unit tests - I quickly realized that they were disconnected, which led me to this. Any work on enhancing the wordbreaker needs these tests fixed first.
@keymanapp-test-bot skip