chore(web): fixup keyboard-processor and input-processor tests 🎡 #6597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some of the test paths required for core tests.
Ref microsoft/TypeScript#32264 (comment) We need getters for the ActiveLayout classes to be enumerable so that we can copy them across in the polyfill functions.
Uses poor man's module mode (i.e. appending .js files) to avoid module issues with the changeover from Lerna to NPM and tsc -b for builds. We will revisit this once the builds have stabilised.
User Test ResultsTest specification and instructions User tests are not required |
github-actions
bot
added
common/
common/core/
common/web/
web/
web/engine/
chore
labels
15 tasks
jahorton
pushed a commit
that referenced
this pull request
May 18, 2022
jahorton
pushed a commit
that referenced
this pull request
May 18, 2022
jahorton
pushed a commit
that referenced
this pull request
May 23, 2022
jahorton
pushed a commit
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses poor man's module mode (i.e. appending .js files) to avoid module issues with the changeover from Lerna to NPM and tsc -b for builds. We will revisit this once the builds have stabilised.
Note a separate fix to workaround a breaking change in tsc 3.9. Ref microsoft/TypeScript#32264 (comment)
We need getters for the ActiveLayout classes to be enumerable so that we can copy them across in the polyfill functions.
@keymanapp-test-bot skip