fix(web): Remove base key from popup keys #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
reviewed
Oct 19, 2020
Co-authored-by: Marc Durdin <[email protected]>
Co-authored-by: Marc Durdin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1113
atm, Keyman for Android on phones includes the base key in the list of popup keys.
This PR standardizes the popup keys by not pre-pending the base key in the popup array.
This also fixes #3092 because now Keyboard creators can control if/where the base key appears in the popup keys.
Screenshots
Mobile viewport
Android emulator