Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Picker + resource updates rework #1842

Merged
merged 16 commits into from
Jun 28, 2019
Merged

[Android] Picker + resource updates rework #1842

merged 16 commits into from
Jun 28, 2019

Conversation

jahorton
Copy link
Contributor

@jahorton jahorton commented Jun 24, 2019 •
edited
Loading

This PR builds upon #1836, allowing the new Settings menus to handle keyboard updates and removing old keyboard management code from the Picker.

Checklist:

  • Remove the '+' button on the Picker and related Picker-centric functionality. (Keep whatever is needed by the Settings menus, though.)
  • Remove all keyboard update check code from the Picker, as it no longer manages app resources.
  • Add keyboard + model update check code to LanguagesSettingsActivity and the CloudRepository class.
  • Properly support lexical model updates.

@jahorton jahorton added this to the P7S1 milestone Jun 24, 2019
@keyman-server
Copy link
Collaborator

OSK renders for Windows

@jahorton jahorton changed the title [WIP] [Android] Picker + resource updates rework [Android] Picker + resource updates rework Jun 25, 2019
@jahorton jahorton marked this pull request as ready for review June 25, 2019 06:00
@jahorton jahorton mentioned this pull request Jun 26, 2019
Merged
mcdurdin
mcdurdin approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes but generally looks good to me

This was referenced Jun 27, 2019
Merged
Merged
mcdurdin
mcdurdin approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Still testing functionality but go ahead and merge down when ready.

android/KMEA/app/src/main/java/com/tavultesoft/kmea/LanguagesSettingsActivity.java
shouldCheckUpdate = true;
}

// TODO: Extremely temporary code for testing - remove before merging!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh! Here's something to do...

@jahorton jahorton merged commit 04f781c into android-settings-ui-rework Jun 28, 2019
@jahorton jahorton deleted the android-picker-rework branch June 28, 2019 22:38
@jahorton jahorton mentioned this pull request Jul 3, 2019
Closed
This was referenced Nov 16, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

Assignees
No one assigned
Labels
android/
Projects
None yet
Milestone
P7S1
Development

Successfully merging this pull request may close these issues.
3 participants
@jahorton @keyman-server @mcdurdin