Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows): check updates and automatic update merged #13115

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rc-swag
Copy link
Contributor

@rc-swag rc-swag commented Feb 3, 2025

Check updates meaning has slightly changed it is now automatic updates and it will now check, download and when possible start the install.

Previously it just meant a check for updates was made and notified the user of updates.

I considered a few options keep the new update registry key added as part of epic/windows-updates and retire the check updates key. I could have the upgrade and first run handle the change and transfer the users intention over to the new key as part of the upgrade.

However, I found there was now real need the meaning has changed slightly but otherwise the keys basically the same therefore I just removed the automatic update key. And updated the Menu it was displayed in and the strings.xml localisation to match.

Fixes:#13114

User Testing

  1. Test that check for updates checked before an updates stays checked after an update.
  2. Test that check for updates unchecked before an updates stays unchecked after an update
  3. Check the automatic update occurs.

TEST_Automatic_update_option_sticks_1

  1. Install Keyman at google drive here
  2. Open the Keyman Configuration dialog.
  3. In Options tab under General, check "Automatically check for updates and download"
  4. Download the update built from this PR.
  5. Double click on the file and in the install options make sure this build is selected to be installed.
  6. Once installed open the Keyman Configuration dialog.
  7. In Options tab under General, make sure "Automatically check for updates and download" is checked.

TEST_Automatic_update_option_sticks_2

  1. Install Keyman at google drive here
  2. Open the Keyman Configuration dialog.
  3. In Options tab under General, uncheck "Automatically check for updates and download"
  4. Download the update built from this PR.
  5. Double click on the file and in the install options make sure this build is selected to be installed.
  6. Once installed open the Keyman Configuration dialog.
  7. In Options tab under General, make sure "Automatically check for updates and download" is unchecked.

TEST_Automatic_update_option_sticks_2

For this test we need to have a build newer then this PR to updated to.

  1. Install Keyman for windows from this PR
  2. Open the Keyman Configuration dialog.
  3. In Options tab under General, check "Automatically check for updates and download"
  4. Also ensure Start with Windows is checked.
  5. Close and exit Keyman.
  6. Open Regedit WinR type regedit
  7. Go to the current user key last update check time found at (Computer\HKEY_CURRENT_USER\SOFTWARE\Keyman\Keyman Desktop).
  8. Modify this value select each hex value and set it to zero see screenshot.
  9. Log out and back in to Windows.
  10. Once windows has restarted. Open Regedit WinR type regedit
  11. Go to the current user key update state found at (Computer\HKEY_CURRENT_USER\SOFTWARE\Keyman\Keyman Engine).
  12. If set the state to usUpdateAvialable->usDownloading->usWaitingRestart you will have to press F5 to refresh
  13. Once it reaches usWaitingRestart log out and back into Windows.
  14. You should be notified a Windows update is available select Update
  15. Keyman for Windows should be installed.
  16. Verify it is update by going to the Keyman Configuration Support tab.

Check updates meaning has slightly changed it is now automatic updates
and it will now check, download and when possible start the install.

Previously it just meant a check for upates was made and notified
the user of updates.

Fixes:#13114
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Feb 3, 2025
@rc-swag rc-swag self-assigned this Feb 3, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Feb 3, 2025

User Test Results

Test specification and instructions

  • TEST_Automatic_update_option_sticks_1 (OPEN)
  • TEST_Automatic_update_option_sticks_2 (OPEN)
  • TEST_Automatic_update_option_sticks_2 (OPEN)
Results Template
# Test Results

* **TEST_Automatic_update_option_sticks_1 (OPEN):** notes
* **TEST_Automatic_update_option_sticks_2 (OPEN):** notes
* **TEST_Automatic_update_option_sticks_2 (OPEN):** notes

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant