feat(developer): include command line in kmc sentry reports #13113
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to reproduce kmc errors, it's very helpful to know how it was instantiated. This change includes the command line call for kmc. This includes things such as a keyboard filename and may include file paths, but does not include private personal information or secrets.
mcdurdin
requested review from
darcywong00,
SabineSIL,
markcsinclair and
srl295
as code owners
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
reviewed
Feb 3, 2025
| * capture an exception for Sentry; note that in local environments, this will normally | ||
| * throw the exception rather than sending to Sentry | ||
| * @param e | ||
| * @param force if true, reports to Sentry even in local environments |
There was a problem hiding this comment.
Does force work as an option in SentryNodeOptions?
Or is it TestKeymanSentry the only intended usage?
There was a problem hiding this comment.
Does
forcework as an option inSentryNodeOptions?
No.
Or is it
TestKeymanSentrythe only intended usage?
Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reproduce kmc errors, it's very helpful to know how it was instantiated. This change includes the command line call for kmc. This includes things such as a keyboard filename and may include file paths, but does not include private personal information or secrets.
Sample capture:
@keymanapp-test-bot skip