Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(ios): set host-app bundle identifier in embedded Web debug-report #13105

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

jahorton
Copy link
Contributor

In our current Sentry reports coming from within the iOS app's keyboard host-page, we get the following under keymanState:

{
  configReport: {
  embeddingApp: AppleTablet,
  hostDevice: {
    browser: native,
    formFactor: tablet,
    OS: ios,
    touchable: true
  },
  initialized: true,
  keymanEngine: app/webview
}

It is certainly helpful to know that the error occurred with the app/webview build on an Apple tablet - that tells us it's from some variant of our iOS engine. But... which one? This PR fetches the active bundle identifier and ferries that into the Web engine once it loads, which will allow us to have the actual active identifier.

  • Is it the Keyman app? Tavultesoft.Keyman.
  • Is it the app's system keyboard? Tavultesoft.Keyman.SWKeyboard
  • Is it coming from a different app that's embedding KeymanEngine? We'll get that identifier here.

I decided to pursue this due to some questions I had after investigation into #13102; namely, we've noticed in the past that users of the FirstVoices app often decide not to utilize sil_euro_latin, which is our engine's default keyboard. There's a chance that #13102 is related to side effects that result when users enforce this preference.

@keymanapp-test-bot skip

@darcywong00 darcywong00 modified the milestones: A18S20, B18S1 Feb 1, 2025
jahorton pushed a commit that referenced this pull request Feb 3, 2025
@jahorton jahorton merged commit 8f89e70 into master Feb 3, 2025
18 checks passed
@jahorton jahorton deleted the change/ios/report-host-app-identifier branch February 3, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants