Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic: ldml editor 🗼 #12759

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

epic: ldml editor 🗼 #12759

wants to merge 25 commits into from
+1,657 −96

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Dec 3, 2024 •
edited by srl295
Loading

@mcdurdin mcdurdin added this to the 19.0 milestone Dec 3, 2024
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Dec 3, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 3, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@srl295 srl295 self-assigned this Dec 3, 2024
mcdurdin and others added 4 commits December 5, 2024 08:49
@mcdurdin
Merge branch 'epic/ldml-editor' into chore/merge-master-into-ldml-editor
cbce5a4
@srl295
Merge pull request #12779 from keymanapp/chore/merge-master-into-ldml…
f68aa39 
…-editor

chore: merge master into ldml-editor 🗼
@srl295
chore(developer): scaffolding for VSCode plugin
0004467 
- empty plugin
- no building nor LDML editing code

Co-authored-by: Marc Durdin <[email protected]>

Fixes: #12798
@srl295
chore(developer): skip vscode test for now 🗼
5d0a993 
- requires X on linux builder, so skip for now

Fixes: #12798
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Dec 6, 2024
@srl295
chore(developer): rename test file🗼
3267652 
- per code review

Fixes: #12789
@srl295
chore(developer): package🗼
97ff64c 
- per code review

Fixes: #12789
@srl295
chore(developer): update build script🗼
3b36e05 
- per code review

Fixes: #12789
@srl295
Merge pull request #12799 from keymanapp/feat/developer/12798-vscode-…
46e544c 
…ext-scaffolding-epic-ldml-editor

feat(developer):  scaffolding for Keyman Developer for VSCode🗼
@srl295 srl295 mentioned this pull request Dec 16, 2024
Open
@srl295 srl295 mentioned this pull request Jan 10, 2025
Open
srl295 and others added 9 commits January 10, 2025 18:11
@srl295
feat(developer): kmx+ to xml
a157183 
- initial steps

Fixes: #12874
@srl295
feat(developer): serialize keybag, preserve import status
e553e0f 
- utility to copy symbols over

Fixes: #12874
@srl295
feat(developer): more steps for XML serializing
31d72e5 
Fixes: #12874
@mcdurdin
Merge branch 'epic/ldml-editor' into chore/merge-master-into-ldml-editor
469d280
@mcdurdin
chore: Merge branch 'master' into chore/merge-master-into-ldml-editor
89b5123
@mcdurdin
Merge pull request #12933 from keymanapp/chore/merge-master-into-ldml…
26c0b2c 
…-editor

chore: merge master into ldml-editor 🗼
@srl295
chore(developer): update serializer 🗼
1703567 
- Note: does not handle transforms yet

Fixes: #12784
@srl295
Merge branch 'epic/ldml-editor' into feat/developer/12874-kmx-to-xml-…
90cc6a0 
…epic-ldml-editor
@srl295
chore(developer): update serializer 🗼
48e57d4 
- workaround transform issue by adding bypass (_) fields in the KMXPlus structs

Fixes: #12784
srl295 added 2 commits January 23, 2025 12:40
@srl295
chore(developer): clarify comments around serializer and KMX+ 🗼
d1c2271 
- clarify the purpose of the serializer and the serializer-required fields in KMXPlusFile
- remove an unused SetVarItems.rawItems property added in #11059

Fixes: #12784
@srl295
Merge pull request #12969 from keymanapp/feat/developer/12874-kmx-to-…
f93c45c 
…xml-epic-ldml-editor

feat(developer): serialize KMXPlus (back) into XML 🗼
@darcywong00 darcywong00 modified the milestones: 19.0, B18S1 Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 will be requested when the pull request is marked ready for review darcywong00 is a code owner

@SabineSIL SabineSIL Awaiting requested review from SabineSIL SabineSIL will be requested when the pull request is marked ready for review SabineSIL is a code owner

@markcsinclair markcsinclair Awaiting requested review from markcsinclair markcsinclair will be requested when the pull request is marked ready for review markcsinclair is a code owner

@srl295 srl295 Awaiting requested review from srl295 srl295 will be requested when the pull request is marked ready for review srl295 is a code owner

@jahorton jahorton Awaiting requested review from jahorton jahorton will be requested when the pull request is marked ready for review jahorton is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@srl295 srl295

Labels
common/web/ common/ developer/compilers/ developer/ epic-ldml-editor
Projects
Keyman
Status: No status
Milestone
B18S1
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdurdin @srl295 @darcywong00