Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Auto-mirror increment and decrement arrows for RTL support 📟 #12230

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Aug 20, 2024

Follows #12227 and #12228 for #12215

This fixes the increment/decrement arrows on the "Text Size" dialog to be RTL compatible.
In RTL locales, the decrement arrow points to the right and increment arrow points to the left.

Also refactored the "Text size: " string so the numerals appear with regular Arabic numbers.

Screenshot

text size

User Testing

Setup - Install the PR build of Keyman for Android on an Android device/emulator. Then in Keyman for Android, change the display language to Arabic (an RTL language)

TEST_TEXT_SIZE - Verifies arrow keys on Text Size dialog are RTL compatible

  1. Launch Keyman for Android where the display language is Arabic.
  2. From the Keyman menu --> Text Size
  3. On the "Text Size" dialog, verify the decrement arrow pointing right makes the text size smaller
  4. On the "Text size" dialog, verify the increment arrow pointing left makes the text size bigger

@darcywong00 darcywong00 requested a review from sgschantz as a code owner August 20, 2024 07:02
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Aug 20, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Aug 20, 2024

User Test Results

Test specification and instructions

@darcywong00 darcywong00 added this to the A18S9 milestone Aug 20, 2024
@darcywong00 darcywong00 changed the title fix(android): Auto-mirror increment and decrement arrows fix(android): Auto-mirror increment and decrement arrows for RTL support Aug 20, 2024
@darcywong00 darcywong00 changed the title fix(android): Auto-mirror increment and decrement arrows for RTL support fix(android): Auto-mirror increment and decrement arrows for RTL support 📟 Aug 20, 2024
@dinakaranr
Copy link

Test Results

  • TEST_TEXT_SIZE (passed):

I retested this issue with the attached "Keyman 18.0.93-alpha-test-12230" build on the Android 14 physical device and Android 12(emulator) Here is my observation.

  1. Installed the "Keyman-18.0.93.apk" file and gave all permissions to the application.
  2. Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard box on the settings page.
  3. Selected the "arabic Phonetic(SIL)" default keyboard.
  4. Open the Keyman app. Enable the "Predictions" to install the "Dictionary."
  5. Change the display UI to "Arabic" by settings/Display Language.
  6. Added a sentence to the notepad.
  7. Open the "Text size" dialog.
  8. Verified the decrement arrow pointing right make the text size smaller when clicking it.
  9. Verified the increment arrow pointing left makes the text size bigger when clicking it.
    Hence, It looks good now. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Aug 21, 2024
Base automatically changed from chore/android/crowdin-ar to master August 21, 2024 12:11
@darcywong00 darcywong00 merged commit 1d42c6e into master Aug 21, 2024
6 checks passed
@darcywong00 darcywong00 deleted the fix/android/texti-size-arrows branch August 21, 2024 12:11
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.94-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants