-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): Enhance how ENTER key is handled in apps #12125
Conversation
User Test ResultsTest specification and instructions Test Artifacts |
Test ResultsI tested this issue with the attached "Keyman 18.0.86-alpha-test-12125" build on the Android 14 physical device. Here is my observation.
|
@dinakaranr - I've made a code change to advance the cursor on newline. @keymanapp-test-bot retest TEST_MESSAGING |
I tested this issue with the attached "Keyman 18.0.86-alpha-test-12125" build on the Android 14 physical device. Here is my observation. Test Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We need a new issue to make the Enter mode visible on the Enter key on the touch keyboard.
Can Shift layer change the Enter mode on other keyboard apps?
} else { | ||
// In-app keyboard uses default ENTER action | ||
keyDownUp(KeyEvent.KEYCODE_ENTER, 0); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it is an opportunity for a future feature?
Changes in this pull request will be available for download in Keyman version 18.0.92-alpha |
Fixes #7796
This PR enhances how the ENTER key is handled as actions in different apps.
In multi-line text (like messaging apps), the enter key inserts a newline (
\n
).When the IME action is Go / Search / Done, the ENTER key sends the corresponding action. (DONE dismisses the keyboard).
Note: EditorInfo also has more actions like PREVIOUS and NEXT, but I didn't bother implementing those this time.
(edit)
From standup, I'll add PREVIOUS and NEXT actions.
Also a future PR for KMW is getting the ENTER key label to change depending on the action
API Changes
to add to help.keyman.com
User Testing
Setup - On an Android device, install the PR build of Keyman for Android. Preferably use a physical device instead of emulator because you'll also need additional Android apps installed:
Setup and enable Keyman as a default system keyboard