-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): enhanced flick resetting via path base-coord replacement 🐵 #10173
Merged
jahorton
merged 5 commits into
feature-gestures
from
feat/web/path-base-coord-replacement
Dec 13, 2023
Merged
feat(web): enhanced flick resetting via path base-coord replacement 🐵 #10173
jahorton
merged 5 commits into
feature-gestures
from
feat/web/path-base-coord-replacement
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions
|
Does not yet replace segment starting coordinate, though.
06eeb96
to
a8e7320
Compare
4cdc1fe
to
6688a58
Compare
ermshiperete
approved these changes
Dec 11, 2023
Base automatically changed from
change/web/path-evaluate-signature
to
feature-gestures
December 13, 2023 07:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than requiring a user to remember exactly where their initial touch location was for a flick during resets, this set of changes allow for flicks to 'change' their start location when reset. A location nearish the center of the base key will always be chosen in a manner that also favors the actual location of the active contact-point when reasonable.
Deliberately not picking the actual center, but an off-center location with a moderate radius of it toward the actual location of a touch, it becomes far easier to swap flick direction intuitively after a reset.
User Testing
TEST_FLICK_LOCKING: Using the standard "Test unminified KeymanWeb" test page from a mobile device...
u
key.û
key in the preview area (assuming it's not blocked by your finger).u
fully recenters: that indicates a successful "reset".ü
as you do so.ú
as you do so.ú
is visible and in the center, lift your finger and end the gesture.ú
is output.a
key; you should see similar previews and text there. (â
,ä
,á
)NOTE: this should replace the corresponding test from Web's regression-test specification if possible. Consider it an update.