change(web): prep for enhanced flick-resets - alters the contact-path evaluation signature 🐵 #10152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
commented
Dec 6, 2023
| @@ -375,7 +375,7 @@ export function flickEndContactModel(params: GestureParams): ContactModel { | |||
| return { | |||
| itemPriority: 1, | |||
| pathModel: { | |||
| evaluate: (path, baseStats) => { | |||
| evaluate: (path, dummy, dummy2, baseStats) => { | |||
There was a problem hiding this comment.
This evaluate function as a whole will be changing in a near-followup, so I was lazy with the dummy-var naming here.
jahorton
force-pushed
the
change/web/path-evaluate-signature
branch
from
4fa268d to
ef247ba
Compare
jahorton
changed the base branch from
feature-gestures
to
feat/web/gesture-path-memory-optimization
ermshiperete
approved these changes
Dec 11, 2023
Base automatically changed from
feat/web/gesture-path-memory-optimization
to
feature-gestures
December 12, 2023 00:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip