change(web): multitap previews now 'look ahead' by an extra rota step 🐵 #10105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined Test Artifacts
|
keymanapp-test-bot
bot
changed the title
|
Closing in favor of #10103; the team all seemed fairly satisfied with its version of multitap previews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare against #10103; this PR simply performs a minor tweak that causes the preview keycaps and hints to "look ahead" by an extra rota step. The net effect: once multitap-mode activates, the currently displayed preview keycap is now the next key to be typed, not the one that was just typed.
I currently think #10102 is more ideal, but it'd be good to test and get feedback from others. There's also a shot that this version is better on tablets, where the preview text is directly on an actual key... meaning that the key would visibly update to the "correct" spot during the finger-lift leading up to its use.
So, to facilitate a comparison version that's demoable, this PR exists.