Fix C code to work with Go 1.11 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akalin-keybase
force-pushed
the
go1.11-fix
branch
from
ca0ef4f to
5fb5871
Compare
|
Also gave Travis perms to access this repo and go-kext, using the newfangled Checks API. |
This was referenced Aug 1, 2018
maxtaco
approved these changes
Aug 1, 2018
|
Ah, this is perfect, thanks! |
akalin-keybase
added a commit
to keybase/go-kext
that referenced
this pull request
Aug 1, 2018
golang/go@94076feef made C type checking stricter. This caused problems where we were passing in nil for CFAllocatorRef, as Go 1.11 will require those to be 0 instead. Use the typed constant kCFAllocatorDefault to avoid this problem. Also add a .travis.yml config and test on various Go versions, including master. This PR is a port of keybase/go-keychain#31 .
jiacfan
pushed a commit
to jiacfan/keychain
that referenced
this pull request
Aug 29, 2018
golang/go@94076feef made C type checking stricter. This caused problems where we were passing in nil for CFAllocatorRef, as Go 1.11 will require those to be 0 instead. Use the typed constant kCFAllocatorDefault to avoid this problem. Also add a .travis.yml config and test on various Go versions, including master. This PR is based on code from keybase#30 by @kevinburkeomg. (cherry picked from commit 15d3657)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang/go@94076feef made C type checking stricter.
This caused problems where we were passing in nil for CFAllocatorRef, as Go 1.11
will require those to be 0 instead.
Use the typed constant kCFAllocatorDefault to avoid this problem.
Also add a .travis.yml config and test on various Go versions, including master.
This PR is based on code from #30 by
@kevinburkeomg.