make Statfs and Fsync timeout faster for unmounting#24433
Merged
Conversation
Otherwise if service has already exited, these calls will hang forever causing both `umount` and `diskutil umount force` to block. Eventually something else kicks in and kills the KBFS process, leaving behind a mount point. With this fix, there's a greater chance that unmounting happens before the KBFS process gets killed.
strib
approved these changes
Jan 26, 2021
songgao
added a commit
that referenced
this pull request
Jan 29, 2021
* make Statfs and Fsync timeout faster for unmounting Otherwise if service has already exited, these calls will hang forever causing both `umount` and `diskutil umount force` to block. Eventually something else kicks in and kills the KBFS process, leaving behind a mount point. With this fix, there's a greater chance that unmounting happens before the KBFS process gets killed. * strib feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise if service has already exited, these calls will hang forever
causing both
umountanddiskutil umount forceto block. Eventuallysomething else kicks in and kills the KBFS process, leaving behind a
mount point. With this fix, there's a greater chance that unmounting
happens before the KBFS process gets killed.