Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of non-existent time zone in fromDateTimeString() #583

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

leftmostcat
Copy link
Collaborator

Timezone.localTimezone is the correct identifier here, not Timezone.floating. The version in trunk will succeed when tzid isn't set on the property (which, when we're defining a time zone, they shouldn't be), as we'll then fall back to Timezone.localTimezone when we instantiate the Time object. However, if tzid were set on the date prop, we could get some odd behavior.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4920724117

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.074%

Totals Coverage Status
Change from base Build 4409613025: 0.0%
Covered Lines: 9271
Relevant Lines: 9438

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants