Support use of timezones specified in ICS #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftmostcat
force-pushed
the
support-embedded-timezones
branch
from
73e1714
to
1d3e74b
Compare
Pull Request Test Coverage Report for Build 4377790006
💛 - Coveralls |
leftmostcat
commented
Mar 7, 2023
leftmostcat
force-pushed
the
support-embedded-timezones
branch
from
1d3e74b
to
70d6702
Compare
kewisch
requested changes
Mar 9, 2023
leftmostcat
force-pushed
the
support-embedded-timezones
branch
from
70d6702
to
b0443a9
Compare
kewisch
approved these changes
Mar 13, 2023
| if (prop.parent.name === 'standard' || prop.parent.name === 'daylight') { | ||
| // Per RFC 5545 3.8.2.4 and 3.8.2.2, start/end date-times within | ||
| // these components MUST be specified in local time. | ||
| zone = Timezone.floating; |
There was a problem hiding this comment.
Where is Timezone.floating defined?
There was a problem hiding this comment.
This may be an error on my part; it should probably be Timezone.localTimezone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no support in ical.js for using a timezone defined within an ICS file for datetimes within that same ICS file. Instead, we are reliant on the TZID used in the file matching one in our time zone database.
In order to prevent bloating the timezone service with one-off time zones or using conflicting definitions, this patch restricts time zones to a single component tree, storing them on the root component and retrieving them from there when referenced.