Skip to content

Bump Selenium.WebDriver from 4.45.0 to 4.46.0 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinoid merged 1 commit into from
Aug 2, 2026
Merged

Bump Selenium.WebDriver from 4.45.0 to 4.46.0 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
-->
<PackageVersion Include="Microsoft.Testing.Extensions.Telemetry" Version="2.3.0" />
<PackageVersion Include="Roslynator.Analyzers" Version="4.15.0" />
<PackageVersion Include="Selenium.WebDriver" Version="4.45.0" />
<PackageVersion Include="Selenium.WebDriver" Version="4.46.0" />
<PackageVersion Include="SonarAnalyzer.CSharp" Version="10.30.0.144632" />
<PackageVersion Include="StyleCop.Analyzers.Unstable" Version="1.2.0.556" />
<PackageVersion Include="xunit.v3.mtp-v2" Version="3.2.2" />
Expand Down
19 changes: 11 additions & 8 deletions ImdbPosterDownloader/Downloader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,15 +144,16 @@ private async IAsyncEnumerable<ImdbPoster> DownloadEpisodesAsyncCore(
await this.biDi.BrowsingContext.ContextCreated.StreamAsync(cancellationToken)
.ConfigureAwait(false);
await using var contextCreatedStreamConf =
((IAsyncDisposable)contextCreatedStream).ConfigureAwait(false);
var contextCreatedEnum = contextCreatedStream.WithTimeout(ContextCreatedTimeout)
contextCreatedStream.ConfigureAwait(false);
var contextCreatedEnum = contextCreatedStream.ReadAllAsync(cancellationToken)
.WithTimeout(ContextCreatedTimeout)
.GetAsyncEnumerator(cancellationToken);
await using var contextCreatedEnumConf = contextCreatedEnum.ConfigureAwait(false);

var loadStream = await this.biDi.BrowsingContext.Load.StreamAsync(cancellationToken)
.ConfigureAwait(false);
await using var loadStreamConf = ((IAsyncDisposable)loadStream).ConfigureAwait(false);
var loadEnum = loadStream.WithTimeout(LoadTimeout)
await using var loadStreamConf = loadStream.ConfigureAwait(false);
var loadEnum = loadStream.ReadAllAsync(cancellationToken).WithTimeout(LoadTimeout)
.GetAsyncEnumerator(cancellationToken);
await using var loadEnumConf = loadEnum.ConfigureAwait(false);

Expand Down Expand Up @@ -288,8 +289,9 @@ private async Task<ImdbPoster> DownloadTitleAsyncCore(
await episodeContext.DomContentLoaded.StreamAsync(cancellationToken)
.ConfigureAwait(false);
await using var episodeDomLoadStreamConf =
((IAsyncDisposable)episodeDomLoadStream).ConfigureAwait(false);
var episodeDomLoadEnum = episodeDomLoadStream.WithTimeout(LoadTimeout)
episodeDomLoadStream.ConfigureAwait(false);
var episodeDomLoadEnum = episodeDomLoadStream.ReadAllAsync(cancellationToken)
.WithTimeout(LoadTimeout)
.GetAsyncEnumerator(cancellationToken);
await using var episodeDomLoadEnumConf = episodeDomLoadEnum.ConfigureAwait(false);

Expand Down Expand Up @@ -374,7 +376,7 @@ private async Task<ImdbPoster> DownloadPosterFromLinkAsync(
await this.context.BiDi.Network.ResponseCompleted.StreamAsync(cancellationToken)
.ConfigureAwait(false);
await using var responseCompletedStreamConf =
((IAsyncDisposable)responseCompletedStream).ConfigureAwait(false);
responseCompletedStream.ConfigureAwait(false);

// Note: BiDiException from Edge if value is above 200,000,000:
// "invalid argument: Max encoded data size should be between 1 and 200000000"
Expand Down Expand Up @@ -406,7 +408,8 @@ await episodeContext.ClickAsync(posterLink, 0, cancellationToken)
.ToHashSet();

using var linkedSource = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
var imageResComp = await responseCompletedStream.FirstAsync(
var imageResComp = await responseCompletedStream.ReadAllAsync(cancellationToken)
.FirstAsync(
rc => lightboxImgSourceSet.Contains(rc.Response.Url),
linkedSource.Token)
.AsTask()
Expand Down