-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate config use pronto yml #15
base: master
Are you sure you want to change the base?
Deprecate config use pronto yml #15
Conversation
Added a new config class. Handle new config from the pronto.yml. Added warning when using the old config. More Rubocop warnings fixed. Added some quality of life improvements to the specs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻 It has been a while since I've done anything with this repo, or even using pronto 😅.
What you are proposing here makes sense though, remove the bespoke config as Pronto has better support for configs of plugins.
I'm thinking it would better to just make a breaking change and adopt the pronto config approach.
Request changes:
- I noticed that tests are emitting the deprecation warning you put in. We would simplify config logic (to the new approach) and just remove the old way.
- Update the README to reflect the new config approach (link to official pronto docs for an example)
🙇🏻 Much appreciated on your contributions, looking forward to the changes.
Also, just notes to me.
It took me a bit to 'run the tests' of this PR, was hitting some node issue with stylelint
(and the meow
package), had to go to the latest node version. Could have a better 'how to test/contribute' in the README.
The CI for this repo doesn't work anymore and probably should just be a GitHub Action now.
Thank you for replying! This is one of many pull requests I've recently submitted to upgrade Pronto plugins. I just wanted to let you know you're the first to reply. |
Remove deprecated code in favour of the new config. Updated the readme. Fixed specs.
@kevinjalbert Sorry about the delay. I was away on vacation and had been unplugged. I've made the changes as you requested! |
Motivation
To reduce the number of config files needed for pronto integrations. Pronto has a config that can handle plugin config.
Changes