Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for initialValues for Checkbox component #380

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update tests for initialValues for Checkbox component #380

wants to merge 3 commits into from

Conversation

jetpack3331
Copy link
Contributor

Tests for initialValues had missing Checkbox values (Bool) so it needs to be added to the tests.

kettanaito
kettanaito approved these changes Apr 30, 2019
View reviewed changes
Copy link
Owner

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you.
I would need to run the tests locally to verify, and then we can merge.

@jetpack3331
Copy link
Contributor Author

Sure :) let me know if you will solve the problem with local cypress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kettanaito kettanaito kettanaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jetpack3331 @kettanaito