Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces selectors API for grouped fields #338

Merged
merged 37 commits into from
Nov 27, 2018

Conversation

kettanaito
Copy link
Owner

@kettanaito kettanaito commented Nov 26, 2018

Change log

Touched

Grouped fields schema selectors

  • Closes Support of grouped fields in validation rules/messages #307
  • Added new API to select grouped fields in validation schema selectors
  • Validation algorithm adjusted to include grouped fields selectors as the highest priority ones
  • Complementary nature of the validation schema resolvers remains as is
  • Removed form.state.applicableRules
  • Form now contains the relevant rules in its state (form.state.rules), which reacts to form.props.rules updates
  • Determination of the relevant rules is delegated to the validation() invocations (the furthest point of calling the validation), to be aligned with the form state changes, and field changes
  • Validation algorithm refactored, removed duplications, aligned to use a single getRulesPath() point to gather the selector keys from the schema

Minor

@kettanaito
Copy link
Owner Author

Updates dependencies after dominictarr/event-stream#116. The malicious package is no longer present as any level dependency of react-advanced-form.

@kettanaito kettanaito force-pushed the 307-validation-grouped-fields branch 3 times, most recently from f1d23a7 to 3e7a41a Compare November 27, 2018 10:30
@kettanaito
Copy link
Owner Author

This should be published under the minor version (1.6). Therefore, the existing pull request for 1.6 will most likely be a subsequent release, or the next minor version.

Copy link
Owner Author

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comment. It's hard to merge things when you develop alone.

@Vidlec Vidlec self-requested a review November 27, 2018 13:05
@kettanaito kettanaito merged commit b910c81 into master Nov 27, 2018
@kettanaito kettanaito deleted the 307-validation-grouped-fields branch November 27, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants