Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "createField.assertValue". Ensures arguments in "shouldValidateOnMount" and validation resolvers #315

Merged
merged 36 commits into from
Nov 1, 2018

Conversation

kettanaito
Copy link
Owner

@kettanaito kettanaito commented Oct 29, 2018

Change log

  • Tree-shakes ramda by using babel-plugin-ramda
  • Cypress: Tests against running Storybook, instead of shallow rendering a scenario component
  • Adds assertValue option for createField to assert the custom value instance of a field (i.e. to know when the value is set in a complex BirthDate component)

Roadmap

  • Add integration test for "BirthDate" field validation
  • Revert integration tests in the build pipeline. Better broken tests, than no test

@kettanaito kettanaito force-pushed the 299-resolver-custom-value-prop-name branch 2 times, most recently from a8289c3 to 88d325c Compare October 29, 2018 18:38
@kettanaito kettanaito force-pushed the 299-resolver-custom-value-prop-name branch from 88d325c to 4938bd7 Compare October 29, 2018 19:31
@kettanaito kettanaito changed the base branch from 1.6 to master October 30, 2018 13:47
@kettanaito kettanaito changed the title Verifies various calls Adds "createField.assertValue". Ensures arguments in "shouldValidateOnMount" and validation resolvers Oct 30, 2018
@kettanaito
Copy link
Owner Author

kettanaito commented Oct 31, 2018

The following must be corrected:

./cypress/support/commands.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
SyntaxError: /root/root/cypress/support/commands.js: Unexpected token, expected ";" (196:50)

  194 |   { prevSubject: true },
  195 |   (subject, errorText) => {
> 196 |     const wrapper = cy.log('Assert error message')wrap(subject).siblings('.invalid-feedback')
      |                                                   ^
  197 | 
  198 |     return errorText === false
  199 |       ? wrapper.should('not.exist')

@kettanaito kettanaito force-pushed the 299-resolver-custom-value-prop-name branch from 135d0f0 to 1d6d903 Compare November 1, 2018 11:07
@kettanaito kettanaito merged commit 1e22689 into master Nov 1, 2018
@kettanaito kettanaito deleted the 299-resolver-custom-value-prop-name branch November 1, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant