-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touched. Fixing CI #302
Touched. Fixing CI #302
Conversation
220bc05
to
3bc50f6
Compare
3bc50f6
to
c64a27f
Compare
There is an issue that field value assertions includes wrong value (i.e. expected I am starting to think it has to do with #268. Still confusing to me why it happens occasionally. Test suits on local in GUI are fine, on local in console are broken. |
51724f1
to
08d9577
Compare
8f0ad58
to
3e92d42
Compare
3e92d42
to
5ee8e3f
Compare
Removing The separate |
Migrating integration test suits to run against open Storybook server. Motivation:
|
I've finished the test migration. What I can see so far, is that building storybook's development version takes very long during the CI. Might consider building production version of storybook, run it, and test against it. That should be generally faster. |
ec82ed9
to
f03f529
Compare
Even after changing the tests to run against Storybook, the pipeline reliability is still poor. As previously, I see tests perfectly passing in both GUI and CLI on local, yet failing on CircleCI. The next strategy is to eliminate context change during tests, meaning that a test scenario is loaded once, and the group of test suits are executed sequentially, without reloading/reseting the scenario. At least, the speed of CI became higher. Going to stay positive about something. |
7f8a7d2
to
62a4a6d
Compare
9dd9bb9
to
ccc9293
Compare
Tried increasing default timeout on Cypress from |
e2f007e
to
aebe72c
Compare
8d319f2
to
c07ee31
Compare
Roadmap
touched
property to the field recordrecordUtils
to ensure default value of thetouched
propertyForm.reset
integration scenarioForm.setErrors()
integration scenario