Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Topology buttons functionality #6983

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

rajatsingh23
Copy link
Contributor

Closes #6949

What changes are being made and why?

  1. Added if statement to treat TOPOLOGY as SOURCE_TOPOLOGY in function handleTopologyEditClick while editing
  2. In Validation.vue the string was treated as array

Copy link
Member

@MilosPaunovic MilosPaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Small note - I've reverted changes inside the kestra/ui/src/components/flows/ValidationError.vue as they were not relevant to closing the issue in question.

@MilosPaunovic MilosPaunovic merged commit 60f96da into kestra-io:develop Jan 28, 2025
2 of 3 checks passed
@rajatsingh23
Copy link
Contributor Author

LGTM! 🚀

Small note - I've reverted changes inside the kestra/ui/src/components/flows/ValidationError.vue as they were not relevant to closing the issue in question.

@MilosPaunovic when I was solving this issue the Error(s) detected was showing each character on new line in the NO_CODE editor. Therefore, on checking I came to know that in ValidationError.vue string was treated as array to render.

And also thanx for this community I just love contributing this repository. It's super helpful and supportive 🚀

@MilosPaunovic
Copy link
Member

Yeah, now that you say it, it does make sense. I'll look into it, but we need to have both approaches working, when it's treated as an array and when not, but thanks for pointing this one out! 👍🏻

This community is lucky to have you! 🚀

@rajatsingh23 rajatsingh23 deleted the fix/add-button-topology branch January 28, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

plus button to add a task in Topology view is not working
2 participants