Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the vite config to use the rollup dependencies properly #6853

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Jan 21, 2025

bundle each common page with its set of dependencies

@elevatebart
Copy link
Contributor Author

cc @smunteankestra

Can you test if this build makes your tests more stable?

TYTY

@smunteankestra
Copy link
Contributor

@Skraye can you please find some time to check the CI? with Skip tests today it failed again

@Skraye
Copy link
Member

Skraye commented Jan 21, 2025

This PR is for Kestra OSS which CI is ok, so you can already test on OSS when this PR will be merge

@elevatebart Stefan dont know how to build locally so you will have to merge it anyway if you want him to test

@smunteankestra smunteankestra merged commit f8b2056 into develop Jan 21, 2025
11 checks passed
@smunteankestra smunteankestra deleted the smart-asset-bundling branch January 21, 2025 12:33
@smunteankestra
Copy link
Contributor

Seems to be better on OSS - but still need to check on EE with automated tests (test are designed for EE),
will check onece a success on EE CI will be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants