Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Docs markdown alert styled based on alert level in product. #6818

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Piyush-r-bhaskar
Copy link
Contributor

@Piyush-r-bhaskar Piyush-r-bhaskar commented Jan 18, 2025

Closes #5629

This needs to checked with PR - kestra-io/ui-libs#154
& need to be merged after the merge of kestra-io/ui-libs#154

dark_Warn_product
light_product

Change in BasicSettings.vue is for maxlength not visible in light mode.

…ion components (Docs, plugin docs, blueprints) use the same markdown style.
@MilosPaunovic
Copy link
Member

I'm assigning @elevatebart here, as he's been working with docs and ui-libs repositories quite recently so he's better person to review this than I am.

@Piyush-r-bhaskar
Copy link
Contributor Author

Hi @elevatebart,

Since we have handled the Alert level styling within Alert.vue. I have removed the styling from DocsLayout.vue and just handled the padding bottom.

To fix FROM
image

TO
image
image

Hopefully the issue: #5629 can be closed after this minor tweak merge as alerts are looking as expected.

Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark and then we can merge TY

@Piyush-r-bhaskar
Copy link
Contributor Author

One small remark and then we can merge TY

@elevatebart sorry but don't see any requested changes.

Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Piyush-r-bhaskar, I forgot to press Send on the comment.

ui/src/components/settings/BasicSettings.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
3 participants