Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ForEach failed with errors, finally and concurrency = 0 #6740

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

tchiotludo
Copy link
Member

No description provided.

@tchiotludo
Copy link
Member Author

@loicmathieu I remove a lot of code in ForEach that didn't work in the past, TBH I didn't see why not reusing the already existing code?

@loicmathieu
Copy link
Member

@tchiotludo this is not the same, resolveConcurrentNexts will resolve values concurrently but not subtasks, whereas resolveParallelNexts will resolve both values and subtasks concurrently which is what EachParallel is doing but we decided not to reproduce on ForEach with concurrency>1 as it creates too many concurrencies.

We had a long discussion about it.

So we need both methods as they do different things.

@tchiotludo
Copy link
Member Author

ok so my fix is not the good one, but each-error flow included failed to work with previous implementation, like all finally one

@tchiotludo tchiotludo merged commit 246602f into develop Jan 16, 2025
11 checks passed
@tchiotludo tchiotludo deleted the fix/foreach branch January 16, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants