fix(core, ui): send a "start" event to be sure the UI receive the SSE #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UI only store a reference to the logs SSE when receive the first event. In case a flow didn't emit any log, or the logs tab is closed before any logs is emitted, the UI will not have any reference to the SSE so the SSE connection would stay alive forever. Each SSE connection starts a thread via the logs queue, creating a thread leak. Sending a first "start" event makes sure the UI has a reference to the SSE.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI only store a reference to the logs SSE when receive the first event. In case a flow didn't emit any log, or the logs tab is closed before any logs is emitted, the UI will not have any reference to the SSE so the SSE connection would stay alive forever. Each SSE connection starts a thread via the logs queue, creating a thread leak.
Sending a first "start" event makes sure the UI has a reference to the SSE.
Closes #6725
Validated manually: before the patch, threads keeps being created and not destroyed for the logQueue, after the patch threads are correctly destroyed.
May fix #3402