Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): Mark taskruns that have attemps in the Gantt view. #6721

Merged
merged 2 commits into from
Jan 16, 2025
Merged

chore(ui): Mark taskruns that have attemps in the Gantt view. #6721

merged 2 commits into from
Jan 16, 2025

Conversation

Piyush-r-bhaskar
Copy link
Contributor

Closes #6653

Implemented to show when attempt > 1

Light:
image

Dark:
image

Used the below flow to reproduce:

namespace: company.team

tasks:
  - id: data_ingestion
    type: io.kestra.plugin.core.flow.Parallel
    tasks:
      - id: salesforce
        type: io.kestra.plugin.airbyte.cloud.jobs.Sync
        connectionId: e3b1ce92-547c-436f-b1e8-23b6936c12ab

      - id: google_analytics
        type: io.kestra.plugin.airbyte.cloud.jobs.Sync
        connectionId: e3b1ce92-547c-436f-b1e8-23b6936c12cd

      - id: facebook_ads
        type: io.kestra.plugin.airbyte.cloud.jobs.Sync
        connectionId: e3b1ce92-547c-436f-b1e8-23b6936c12ef

  - id: dbt_cloud_job
    type: io.kestra.plugin.dbt.cloud.TriggerRun
    jobId: "396284"
    accountId: "{{ secret('DBT_CLOUD_ACCOUNT_ID') }}"
    token: "{{ secret('DBT_CLOUD_API_TOKEN') }}"
    wait: true

pluginDefaults:
  - type: io.kestra.plugin.airbyte.cloud.jobs.Sync
    values:
      token: "{{ secret('AIRBYTE_CLOUD_API_TOKEN') }}"

@MilosPaunovic MilosPaunovic self-requested a review January 13, 2025 07:03
@MilosPaunovic MilosPaunovic self-assigned this Jan 13, 2025
MilosPaunovic
MilosPaunovic approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@MilosPaunovic MilosPaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@MilosPaunovic MilosPaunovic merged commit aa450d6 into kestra-io:develop Jan 16, 2025
3 checks passed
@loicmathieu
Copy link
Member

Thanks @Piyush-r-bhaskar !

@Piyush-r-bhaskar Piyush-r-bhaskar deleted the issue_6653 branch January 27, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilosPaunovic MilosPaunovic MilosPaunovic approved these changes

Assignees

@MilosPaunovic MilosPaunovic

Labels
None yet
Projects
Pull Requests
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Mark taskruns that have attemps in the Gantt view
3 participants
@Piyush-r-bhaskar @loicmathieu @MilosPaunovic