Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): added empty view if there are no executions in progress #6640

Merged

Conversation

hashimzs
Copy link
Contributor

@hashimzs hashimzs commented Jan 6, 2025

What changes are being made and why?

closes #5773
in the concurrency tab in namespaces an empty view should be shown instead of normal view

How the changes have been QAed?


image

Thank you for your contribution. ❤️ -->

@MilosPaunovic MilosPaunovic self-requested a review January 8, 2025 08:07
@MilosPaunovic MilosPaunovic self-assigned this Jan 8, 2025
@hashimzs
Copy link
Contributor Author

hashimzs commented Jan 9, 2025

@MilosPaunovic i have updated the en.json file for translations

@hashimzs
Copy link
Contributor Author

hashimzs commented Jan 9, 2025

@MilosPaunovic i can see that a unit test for the frontend have failed since the keys I have added dont have translations in all languages. and that is due tp the generate translations workflow failing is there something i can do on my end

@MilosPaunovic
Copy link
Member

Don't worry @hashimzs, it's because we don't run automation directly on the forked repositories. Give me couple of days to get something else done and I'll check the PR, after which I'll get back to you.

Copy link
Member

@MilosPaunovic MilosPaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@MilosPaunovic MilosPaunovic merged commit fb66d42 into kestra-io:develop Jan 16, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Flow Concurrency tab didn't look well when nothing is running
2 participants