Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): throw an error if the secret is not found #6495

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat(core): throw an error if the secret is not found #6495

merged 1 commit into from
Dec 17, 2024

Conversation

loicmathieu
Copy link
Member

Throw an error if the secret is not found instead of returning null

@loicmathieu loicmathieu added the kind/breaking-change Code modifications needed before upgrading label Dec 17, 2024
@loicmathieu
Copy link
Member Author

Breaking change

Fetching a secret from the secret() function that is not defined, previously returned null in the OSS version and now throws an exception.
This align the OSS behavior with the EE behavior when fetching a secret that didn't exist in the secret manager was already throwing an exception.

@loicmathieu loicmathieu merged commit da1bbb5 into develop Dec 17, 2024
6 of 8 checks passed
@loicmathieu loicmathieu deleted the fix/secret-not-found branch December 17, 2024 14:09
@Ben8t Ben8t mentioned this pull request Dec 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/breaking-change Code modifications needed before upgrading
Projects
Issues
Status: Done
Pull Requests
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@loicmathieu