-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align the CSS or style configuration so that all documentation components (Docs, plugin docs, blueprints) use the same markdown style #5629
Comments
You can use this |
Can I please be assigned this issue? I am a beginner and very interested in contributing. |
Go for it @talamo13! 🚀 |
this seems to be an interesting issue ! if it hasnt been resolved till now I'm interested to work on it. |
I have started working on this issue but I'm little doubtful if I'm doing it right. if possible please provide me little more context about this issue. it would be really helpful. |
What seems to be the issue you're having trouble with @SarthakBorude? |
@MilosPaunovic actually I'm a little confused about which markdown style is mentioned in the issue.If possible please provide me more details. So I can work accordingly. |
the style used for markdown |
Hi @anna-geller @MilosPaunovic , Sorry to jump in. I was just exploring this. I believe plugin docs attached image text - This feature has been moved to a new location is from BE and icon used is just an emoji. that's why this is not inline with Docs markdown. For icon to appear in Docs as per @Nico-Kestra design May be we need to make some changes in Just asking if there is need of icon for now or can this be only text ? Then, we can just remove the emoji for some of plugin docs alert. |
|
The icon in the blue info notice should also be blue ideally (not black). big thanks for picking up this topic @Piyush-r-bhaskar! |
Hi @anna-geller & @MilosPaunovic, How you liked it ? docs.markdown.mp4docs.markdown_2.mp4As you know DOCs are using Bootstrap Alerts (not Your suggestions please ? Also, any ideas from current assignees most welcome. @SarthakBorude @talamo13 |
Heads up @Piyush-r-bhaskar, this will have to wait for @anna-geller's input, but as today is her last day before holidays, we might postpone it for a bit, as it's lower priority for now. |
Sure @MilosPaunovic 😊 |
@anna-geller We might need you input here to proceed. |
@Piyush-r-bhaskar Does that answer you questions or do you need something else to proceed? |
Sure @anna-geller That would be great. Thank you. Yes @MilosPaunovic Thank You. So, I want to proceed like below:
Please I would love your suggestion for making it more perfect and clean. or Of course during review too 😃 Most probably I will open a PR for this before Friday because currently have a Major Release on Tuesday (Hopefully it will go as per Go/No Go Assessment 😁) |
Pinging @elevatebart, as he might be better suited to review this once the PR is opened, as reccently he's been doing work around both |
…con. This PR should be checked with Relates to kestra-io/kestra#5629
…154) * chore(ui): Add a new design of alerts according to alert level with icon. This PR should be checked with Relates to kestra-io/kestra#5629 * fix : remove inline svg and use vue icons
Feature description
Currently things like info blocks differ for Docs and markdown in plugin docs:
plugin docs:
We should use the same markdown style everywhere for consistency - ideally, let's follow the one used in Docs
The text was updated successfully, but these errors were encountered: