Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry support for workflows #6149

Closed
grozdz opened this issue Nov 27, 2024 · 5 comments · Fixed by #6817
Closed

OpenTelemetry support for workflows #6149

grozdz opened this issue Nov 27, 2024 · 5 comments · Fixed by #6817
Assignees
Labels
area/backend Needs backend code changes enhancement New feature or request

Comments

@grozdz
Copy link

grozdz commented Nov 27, 2024

Feature description

Hi All,

I have a generic suggestion about traces. In our setup, we trigger Kestra workflows from our microservices which are instrumented with Open Telemetry. This way we can observe how requests go through our infrastructure. It would be great to add possibility to instrument workflows and send traces to Open Telemetry collector, so we can see Kestra workflow as part of traces and service graph. I was told on Slack that there is no such feature so far, so I'm proposing it.

Best regards,
Grzegorz

@grozdz grozdz added area/backend Needs backend code changes area/frontend Needs frontend code changes enhancement New feature or request labels Nov 27, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 27, 2024
@loicmathieu
Copy link
Member

Hi,
Small question to pinpoint this feature request.
Do you want a Kestra workflow execution to be a single span for the whole execution or to have one span per tasks?

@grozdz
Copy link
Author

grozdz commented Nov 29, 2024

Hi,
I think it would be great to have possibility to choose, e.g. parameterize it per flow. In our case certain flows are more complex than others, so it would be great to have visibility per task. But single span would be great option too.

@loicmathieu loicmathieu self-assigned this Dec 3, 2024
@Ben8t
Copy link
Member

Ben8t commented Dec 11, 2024

As Loic has a working code already, let's keep it for 0.21.
It's a great addition! Though a different subject, it perfectly matches the theme of "Log Shipper" for the coming release cc @anna-geller

Remaining work (@loicmathieu please add additional items if needed):

  • Naming convention for trace/span. Idea for now is to refer traces to the corresponding Kestra component (executor, queue, etc.)
  • configuration refinement?

@loicmathieu loicmathieu removed the area/frontend Needs frontend code changes label Dec 11, 2024
loicmathieu added a commit that referenced this issue Jan 18, 2025
loicmathieu added a commit that referenced this issue Jan 20, 2025
loicmathieu added a commit that referenced this issue Jan 20, 2025
@Ben8t
Copy link
Member

Ben8t commented Jan 21, 2025

@loicmathieu is still manageable to have this in 0.21? Or best to move for next release?

@loicmathieu
Copy link
Member

Yes, a PR is openned and ready to be merged.
But I have another PR that modified the same code that is opened and not ready, so I was waiting for this one to avoid too complex merge.

I'll merge everything tomorrow...

@Ben8t Ben8t moved this from Backlog to In progress in Issues Jan 21, 2025
loicmathieu added a commit that referenced this issue Jan 22, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Issues Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants