Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin icons are not rendered correctly in the Outputs tab for errors tasks #5643

Closed
anna-geller opened this issue Oct 23, 2024 · 8 comments · Fixed by #6654
Closed

Plugin icons are not rendered correctly in the Outputs tab for errors tasks #5643

anna-geller opened this issue Oct 23, 2024 · 8 comments · Fixed by #6654
Assignees
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors

Comments

@anna-geller
Copy link
Member

anna-geller commented Oct 23, 2024

Describe the issue

image

Reproducer flow

id: errors
namespace: company.team

tasks:
  - id: hello
    type: io.kestra.plugin.core.log.Log
    message: Starting the workflow
  - id: fail
    type: io.kestra.plugin.core.execution.Fail

errors:
  - id: return
    type: io.kestra.plugin.core.output.OutputValues
    values:
      message: "{{ error.message }}"
      taskId: "{{ error.taskId }}"
      stacktrace: "{{ error.stackTrace }}"

  - id: error_log
    type: io.kestra.plugin.core.log.Log
    message:
      - "It's the fault of '{{ error.taskId }}'"
      - "See the message: {{ error.message }}"
      - "{{ error.stackTrace }}"

Environment

  • Kestra Version: develop
@anna-geller anna-geller added bug Something isn't working area/frontend Needs frontend code changes good first issue Great issue for new contributors labels Oct 23, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Oct 23, 2024
@Nbs-26
Copy link

Nbs-26 commented Oct 23, 2024

Hello @anna-geller! I understood the issue. Can you please assign this issue to me because I am really excited to try it out since I m a beginner!

@Varshap2205
Copy link

hello I am interested to work on this could you please assign it to me?

@MilosPaunovic
Copy link
Member

@Varshap2205 Let's first way if @Nbs-26 is working on it, if not, you can take over.

@Nbs-26
Copy link

Nbs-26 commented Oct 28, 2024

Hello @MilosPaunovic ! Yaa, I am working on it. But, I am finding it a bit difficult to debug it. I need some more time. Meanwhile ,you can have @Varshap2205 to work on it too, if possible.

@rohitg00
Copy link
Contributor

rohitg00 commented Nov 2, 2024

Hello @anna-geller, I made some changes to the code that help resolve this issue. Can you take a look and provide me with feedback? Thanks

@MilosPaunovic MilosPaunovic assigned rohitg00 and unassigned Nbs-26 and Varshap2205 Nov 3, 2024
@anna-geller anna-geller moved this from Backlog to In review in Issues Nov 19, 2024
@MilosPaunovic
Copy link
Member

This is still open for grabs, if some contributor wants to tackle it. Although, it might involve some backend and a lot of exploring.

@MilosPaunovic MilosPaunovic added the area/backend Needs backend code changes label Dec 4, 2024
@anna-geller anna-geller moved this from In review to Backlog in Issues Dec 4, 2024
@aabhas-sao
Copy link
Contributor

Hey @MilosPaunovic,
can you please assign me this issue.
For now I checked the issue for some time and I have found out below.
errors is not sent from the backend, So icon cls for the errors tasks is coming undefined in component.

@aabhas-sao
Copy link
Contributor

Hi @MilosPaunovic,
please check out PR. had to make one update for null check. please squash before merging.

@anna-geller anna-geller moved this from Backlog to In review in Issues Jan 7, 2025
@Skraye Skraye closed this as completed in 111493c Jan 7, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in Issues Jan 7, 2025
tchiotludo added a commit that referenced this issue Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants