fix(core): reset the MDC when we clean the run context

core/src/main/java/io/kestra/core/runners/DefaultRunContext.java

@@ -474,6 +474,8 @@ public void cleanup() {
         } catch (IOException ex) {
             logger().warn("Unable to cleanup worker task", ex);
         }
+
+        logger.resetMDC();
     }
 
     /**

core/src/main/java/io/kestra/core/runners/ExecutorService.java

@@ -407,7 +407,7 @@ private Executor onEnd(Executor executor) {
 
         logService.logExecution(
             newExecution,
-            flow.logger(),
+            logger,
             Level.INFO,
             "Flow completed with state {} in {}",
             newExecution.getState().getCurrent(),

core/src/main/java/io/kestra/core/runners/RunContext.java

@@ -126,6 +126,7 @@ public abstract class RunContext {
 
     /**
      * Cleanup any temporary resources, files created through this context.
+     * Also reset logs MDC so the logger should not be used after this point.
      */
     public abstract void cleanup();
 

core/src/main/java/io/kestra/core/runners/RunContextLogger.java

@@ -192,6 +192,10 @@ public org.slf4j.Logger logger() {
         return this.logger;
     }
 
+    public void resetMDC() {
+        MDC.clear();
+    }
+
     @Override
     public org.slf4j.Logger get() {
         return logger();

core/src/main/java/io/kestra/core/runners/Worker.java

@@ -398,8 +398,8 @@ private void handleTask(final WorkerTask workerTask) {
                     }
                 }
             } finally {
-                runContext.cleanup();
                 this.logTerminated(workerTask);
+                runContext.cleanup();
             }
         } else {
             throw new RuntimeException("Unable to process the task '" + workerTask.getTask().getId() + "' as it's not a runnable task");
@@ -570,8 +570,6 @@ private void handleTrigger(WorkerTrigger workerTrigger) {
                     } catch (Exception e) {
                         this.handleTriggerError(workerTrigger, e);
                     } finally {
-                        workerTrigger.getConditionContext().getRunContext().cleanup();
-
                         logService.logTrigger(
                             workerTrigger.getTriggerContext(),
                             runContext.logger(),
@@ -580,6 +578,8 @@ private void handleTrigger(WorkerTrigger workerTrigger) {
                             workerTrigger.getTrigger().getType(),
                             DurationFormatUtils.formatDurationHMS(stopWatch.getTime(TimeUnit.MILLISECONDS))
                         );
+
+                        workerTrigger.getConditionContext().getRunContext().cleanup();
                     }
 
                     this.evaluateTriggerRunningCount.get(workerTrigger.getTriggerContext().uid()).addAndGet(-1);
@@ -691,12 +691,12 @@ private WorkerTaskResult run(WorkerTask workerTask, Boolean cleanUp) {
             }
             return workerTaskResult;
         } finally {
+            this.logTerminated(workerTask);
+
             // remove tmp directory
             if (cleanUp) {
                 workerTask.getRunContext().cleanup();
             }
-
-            this.logTerminated(workerTask);
         }
     }