chore(test): add required attributes for e2e test (#6797)

kestra-io · Jan 16, 2025 · 52aa0d6 · 52aa0d6
1 parent f5dc67f
commit 52aa0d6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/ui/src/components/code/components/collapse/Element.vue b/ui/src/components/code/components/collapse/Element.vue
@@ -13,7 +13,6 @@
 <script setup lang="ts">
     import {computed} from "vue";
 
-    // TODO: Update import once https://github.com/kestra-io/kestra/pull/6643 is merged
     import TaskIcon from "@kestra-io/ui-libs/src/components/misc/TaskIcon.vue";
 
     const props = defineProps({

diff --git a/ui/src/components/filter/KestraFilter.vue b/ui/src/components/filter/KestraFilter.vue
@@ -28,11 +28,8 @@
                 dashboards: dashboards.shown,
             }"
             @focus="handleFocus"
+            data-test-id="KestraFilter__select"
         >
-            <!--
-                TODO: Possible approach to solving https://github.com/kestra-io/kestra/issues/6238 might
-                be custom tag slot https://element-plus.org/en-US/component/select.html#custom-tag
-            -->
             <template #label="{value}">
                 <Label :option="value" />
             </template>
@@ -46,11 +43,12 @@
             </template>
             <template v-if="dropdowns.first.shown">
                 <el-option
-                    v-for="option in includedOptions"
+                    v-for="(option, index) in includedOptions"
                     :key="option.value"
                     :value="option.value"
                     :label="option.label"
                     @click="() => filterCallback(option)"
+                    :data-test-id="`KestraFilter__type__${index}`"
                 >
                     <component
                         v-if="option.icon"
@@ -62,7 +60,8 @@
             </template>
             <template v-else-if="dropdowns.second.shown">
                 <el-option
-                    v-for="comparator in dropdowns.first.value.comparators"
+                    v-for="(comparator, index) in dropdowns.first.value
+                        .comparators"
                     :key="comparator.value"
                     :value="comparator"
                     :label="comparator.label"
@@ -72,11 +71,12 @@
                         ),
                     }"
                     @click="() => comparatorCallback(comparator)"
+                    :data-test-id="`KestraFilter__comparator__${index}`"
                 />
             </template>
             <template v-else-if="dropdowns.third.shown">
                 <el-option
-                    v-for="filter in valueOptions"
+                    v-for="(filter, index) in valueOptions"
                     :key="filter.value"
                     :value="filter"
                     :label="filter.label"
@@ -90,6 +90,7 @@
                     @click="
                         () => !isOptionDisabled(filter) && valueCallback(filter)
                     "
+                    :data-test-id="`KestraFilter__value__${index}`"
                 />
             </template>
         </el-select>