Skip to content

Commit

Permalink
fix(ui): watch arguments are inverted
Browse files Browse the repository at this point in the history
  • Loading branch information
tchiotludo committed Jan 13, 2023
1 parent 39f584a commit 2d069eb
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion ui/src/components/executions/ExecutionRoot.vue
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
this.previousExecutionId = this.$route.params.id
},
watch: {
$route(oldValue, newValue) {
$route(newValue, oldValue) {
this.$store.commit("execution/setTaskRun", undefined);
this.$store.commit("execution/setTask", undefined);
if (oldValue.name === newValue.name && this.previousExecutionId !== this.$route.params.id) {
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/executions/Gantt.vue
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
};
},
watch: {
execution(oldValue, newValue) {
execution(newValue, oldValue) {
if (oldValue.id !== newValue.id) {
this.realTime = true;
this.paint();
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/executions/Overview.vue
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
}
},
watch: {
$route(oldValue, newValue) {
$route(newValue, oldValue) {
if (oldValue.name === newValue.name && this.execution.id !== this.$route.params.id) {
this.$store.dispatch(
"execution/loadExecution",
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/executions/Restart.vue
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
},
emits: ["follow"],
watch: {
isOpen(newValue, oldValue) {
isOpen(newValue) {
if (newValue) {
this.loadRevision()
}
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/flows/FlowRoot.vue
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
};
},
watch: {
$route(oldValue, newValue) {
$route(newValue, oldValue) {
if (oldValue.name === newValue.name) {
this.load()
}
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/layout/Duration.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
}
},
watch: {
histories(oldValue, newValue) {
histories(newValue, oldValue) {
if (oldValue[0].date !== newValue[0].date) {
this.paint()
}
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/layout/SearchField.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
}
},
watch: {
$route(oldValue, newValue) {
$route(newValue, oldValue) {
if (oldValue.name === newValue.name) {
this.init()
}
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/plugins/Plugin.vue
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
this.loadPlugin()
},
watch: {
$route(oldValue, newValue) {
$route(newValue, oldValue) {
if (newValue.name.startsWith("plugins/")) {
this.onRouterChange();
}
Expand Down
2 changes: 1 addition & 1 deletion ui/src/mixins/dataTableActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default {
},
},
watch: {
$route(oldValue, newValue) {
$route(newValue, oldValue) {
if (oldValue.name === newValue.name && newValue.query !== oldValue.query) {
this.load(this.onDataLoaded);
}
Expand Down

0 comments on commit 2d069eb

Please sign in to comment.