Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remaining rt-tests #417

Closed
musamaanjum opened this issue Jul 19, 2024 · 3 comments · Fixed by kernelci/kernelci-core#2665
Closed

Enable remaining rt-tests #417

musamaanjum opened this issue Jul 19, 2024 · 3 comments · Fixed by kernelci/kernelci-core#2665
Assignees

Comments

@musamaanjum
Copy link

The following 4 tests were enabled. The maintainter was only enabling these 4 in this PRs, so we had enabled these 4 only as the first step.
cyclictest
cyclicdeadline
rtla-osnoise
rtla-timerlat

Enable the following tests as well:
pi-stress
pmqtest
ptsematest
rt-migrate-test
signaltest
sigwaittest
svsematest

@igaw
Copy link

igaw commented Aug 21, 2024

The reason why only four tests are enabled is to keep the runtime in the same ball park is it was before. Sure, it would be good to run the other tests too. What would be an acceptable runtime for the tests? I am asking because most of these tests should be run for a longer period to catch outliers. If we run them only for a minute it, it is basically a smoke tests. This is also okay but it wont give me any warm fuzzy feeling if the RT patched kernel is behaving any good.

So if the goal is to have a quick smoke test run, I'd say enable them and let them run for a minute. We could define one test case to run a bit longer which has potential to catch outliers, e.g. rtla-osnoise with a couple of different workloads.

@musamaanjum
Copy link
Author

I'll enable the remaining tests as well.

As far as the duration of tests is concerned, the current running time is 60 seconds by default. We can have a look at the load on the devices and increase the running time of all these tests. Or we can also increase the running time of rtla-osnoise as a starting point and go from there.

@nuclearcat @igaw what could be the realistic and reasonable time for these tests? Would 5 or 10 minutes be enough?

cc: @helen-fornazier

@nuclearcat
Copy link
Member

Yes, i think 10 minutes as upper limit are fine.

musamaanjum added a commit to musamaanjum/kernelci-core that referenced this issue Sep 11, 2024
Add default timeout value to template and set it to 10 minutes. Also
increase the duration of test to 10 minutes.

Close kernelci/kernelci-project#417

Signed-off-by: Muhammad Usama Anjum <[email protected]>
github-merge-queue bot pushed a commit to kernelci/kernelci-core that referenced this issue Sep 13, 2024
Add default timeout value to template and set it to 10 minutes. Also
increase the duration of test to 10 minutes.

Close kernelci/kernelci-project#417

Signed-off-by: Muhammad Usama Anjum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants