Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build KernelCI API production image #126

Merged

Conversation

pawiecz
Copy link
Contributor

@pawiecz pawiecz commented Jan 31, 2024

This PR depends on kernelci/kernelci-core#2332

@pawiecz
Copy link
Contributor Author

pawiecz commented Jan 31, 2024

Please do not merge: --version argument is broken (taken from core, not api) and there's also pip install issue when building the image (which might be unrelated to this patch but still requires resolving).

@nuclearcat nuclearcat marked this pull request as draft January 31, 2024 10:44
@nuclearcat
Copy link
Member

I converted to draft so it wont be merged by mistake. You can "undraft" it when it is ready

@pawiecz
Copy link
Contributor Author

pawiecz commented Jan 31, 2024

Issue with pip install was caused by upgrading base image from python:3.10 to python3.11 (like other Python-based images, see base fragment). Install fails for httptools package.

Relevant issue: cython/cython#4428.

This change depends on kernelci/kernelci-core#2332

Updating API branch has been moved to the beginning of the run. It is
meant to remove the possibility of pushing other images to the Docker
registry than will be deployed on the instance. This will become
irrelevant once deployment is migrated to versioned images instead of
docker-compose-built ones.

Signed-off-by: Paweł Wieczorek <[email protected]>
This change depends on kernelci/kernelci-core#2332

Signed-off-by: Paweł Wieczorek <[email protected]>
@pawiecz pawiecz force-pushed the build-kernelci-api-production-image branch from a098207 to cfe858d Compare January 31, 2024 12:17
@pawiecz
Copy link
Contributor Author

pawiecz commented Jan 31, 2024

Version issue resolved in the latest PR revision, install issue resolved in kernelci/kernelci-core#2332 - once the latter is merged, I'll undraft this change (even though it's ready now)

@pawiecz pawiecz marked this pull request as ready for review February 1, 2024 10:34
@nuclearcat
Copy link
Member

Lets try! :)

@nuclearcat nuclearcat merged commit ec75cc1 into kernelci:main Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants