config: rt-tests: set default priority of rt-migrate test #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The priority of 96 if passed to rt-migrate causes failure. The test isn't designed well to handle high priority of 96. The test takes this priority and adds the count of number of tasks which becomes greater than 99. The 99 is the highest priority level for SCHED_FIFO. Hence, the priority setting of the main thread fails, we get warning and later test failure: Warning, can't set priority of main thread! Instead of fixing the test at this time, let's use priority of 90 instead of 96 such that the total priority of main thread remains below highest priority level. We can set any other lower priority than 90 here as well such as 51 which is set in the rt-migrate-test.sh by default. Relates kernelci/kernelci-project#439 Signed-off-by: Muhammad Usama Anjum <[email protected]>
|
I'm not sure from where priority 96 was coming for rt-migrate test. Let's wait for a test run to verify if this patch is correct before merging this. |
|
Confirmed: https://lava.collabora.dev/scheduler/job/15747113 @nuclearcat let's merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The priority of 96 if passed to rt-migrate causes failure. The test isn't designed well to handle high priority of 96. The test takes this priority and adds the count of number of tasks which becomes greater than 99. The 99 is the highest priority level for SCHED_FIFO. Hence, the priority setting of the main thread fails, we get warning and later test failure:
Warning, can't set priority of main thread!
Instead of fixing the test at this time, let's use priority of 90 instead of 96 such that the total priority of main thread remains below highest priority level. We can set any other lower priority than 90 here as well such as 51 which is set in the rt-migrate-test.sh by default.
Relates kernelci/kernelci-project#439
Signed-off-by: Muhammad Usama Anjum [email protected]