Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.74 #2250

Merged
merged 5 commits into from
Dec 25, 2023
Merged

Rust 1.74 #2250

merged 5 commits into from
Dec 25, 2023

Conversation

ojeda
Copy link
Contributor

@ojeda ojeda commented Dec 14, 2023

Rust 1.74.1 will likely be the next version supported by the kernel [1].

Therefore, add it as a new build environment.

Link: https://lore.kernel.org/rust-for-linux/[email protected]/ [1]

See also: kernelci/kernelci-deploy#113 and kernelci/kernelci-deploy#114.

Rust 1.74.1 will likely be the next version supported by the kernel [1].

Therefore, add it as a new build environment.

Link: https://lore.kernel.org/rust-for-linux/[email protected]/ [1]
Signed-off-by: Miguel Ojeda <[email protected]>
@aliceinwire aliceinwire self-assigned this Dec 19, 2023
@aliceinwire aliceinwire self-requested a review December 19, 2023 00:25
@aliceinwire aliceinwire added the Rust rust-for-linux related label Dec 19, 2023
@aliceinwire
Copy link
Member

Thanks, currently testing this

@aliceinwire
Copy link
Member

tested and worked but as the rust: upgrade to Rust 1.74.1 is not yet in rust-next it throws errors and kernel not build
wait for the rust-next to be upgraded to Rust 1.74.1 before merging

@ojeda
Copy link
Contributor Author

ojeda commented Dec 20, 2023

Thanks a lot Alice!

wait for the rust-next to be upgraded to Rust 1.74.1 before merging

I think @gctucker preferred to update KernelCI first (#1890 (review)). For me, either way it is OK :)

In any case, I will apply the upgrade to rust-next soon (e.g. later today perhaps).

@ojeda
Copy link
Contributor Author

ojeda commented Dec 22, 2023

I applied Rust 1.74.1 yesterday, i.e. rust-next is now using it.

@aliceinwire
Copy link
Member

Thanks a lot Alice!

wait for the rust-next to be upgraded to Rust 1.74.1 before merging

I think @gctucker preferred to update KernelCI first (#1890 (review)). For me, either way it is OK :)

In any case, I will apply the upgrade to rust-next soon (e.g. later today perhaps).

I see, I'm also ok on updating KernelCI first

@aliceinwire aliceinwire added this pull request to the merge queue Dec 25, 2023
Merged via the queue into kernelci:main with commit 6c158fe Dec 25, 2023
4 checks passed
@ojeda ojeda deleted the rust-1.74 branch December 25, 2023 00:48
@ojeda
Copy link
Contributor Author

ojeda commented Dec 25, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust rust-for-linux related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants