Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-configs.yaml: move rust-next to Rust 1.68 #1926

Merged
merged 1 commit into from
May 15, 2023

Conversation

ojeda
Copy link
Contributor

@ojeda ojeda commented May 8, 2023

This moves both rust-for-linux_rust-next and next's Rust variant.

As discussed [1], for this kind of upgrades, we will move KernelCI first and then I will apply push the branch. The run is expected to fail if it happens to run between those two moves.

Link: #1890 (comment) [1]

This moves both `rust-for-linux_rust-next` and `next`'s Rust variant.

As discussed [1], for this kind of upgrades, we will move KernelCI first
and then I will apply push the branch. The run is expected to fail if
it happens to run between those two moves.

Link: kernelci#1890 (comment) [1]
Signed-off-by: Miguel Ojeda <[email protected]>
@gctucker
Copy link
Contributor

This is now going to be deployed on staging.kernelci.org and it should be tested with a full linux-next build this weekend. As long as this produces meaningful results it should land in production next week.

@ojeda
Copy link
Contributor Author

ojeda commented May 10, 2023

Thanks Guillaume!

Will similar updates (i.e. upgrades to the Rust compiler) take about a week to land, usually? (i.e. asking so that I can schedule/plan the PRs accordingly)

@gctucker
Copy link
Contributor

Production updates for linux.kernelci.org typically happen every Monday, so yes by default it should take at most a week. If you need to fast-track something that's always possible with some more manual intervention.

In the meantime there should be some results on staging by tomorrow here:
https://staging.kernelci.org/job/kernelci/branch/staging-next/

Today's build was with rust-1.62 but I've also updated the staging config to start using 1.68.

@ojeda
Copy link
Contributor Author

ojeda commented May 10, 2023

Sounds good, thanks a lot!

@gctucker
Copy link
Contributor

There's an issue, the Docker image is missing for the staging builds:

$ docker pull kernelci/staging-rustc-1.68:x86-kselftest-kernelci
Error response from daemon: manifest for kernelci/staging-rustc-1.68:x86-kselftest-kernelci not found: manifest unknown: manifest unknown

Taking a look, I think a new repository should be added in Docker Hub. The kernel build with rustc-1.68 can be rerun once that's fixed so I'll post an update later.

@gctucker
Copy link
Contributor

OK the image being built didn't have the x86 bit in the tag... That's fixed now.

@gctucker
Copy link
Contributor

Results are in:
https://staging.kernelci.org/build/id/645cbbcc0287ee3ed8134cdf/

@ojeda There are build errors but I guess that's expected based on previous discussions. Please confirm this is OK and we can merge the PR.

@ojeda
Copy link
Contributor Author

ojeda commented May 11, 2023

The build log looks fine to me, thanks!

I would expect perhaps some of the lines from kernel.log to be in build-errors.log, but it is not a big deal (and independent of this PR).

@gctucker
Copy link
Contributor

More results from the full linux-next build on staging from this weekend:
https://staging.kernelci.org/build/id/64606ebc88b39fe42a134ceb/ (x86_64_defconfig+rust-samples, passing)
https://staging.kernelci.org/build/id/646069e10188f94bf7134d1f/ (x86_64_defconfig+rust, failing)

@gctucker gctucker added this pull request to the merge queue May 15, 2023
Merged via the queue into kernelci:main with commit a24fc7e May 15, 2023
@ojeda ojeda deleted the rust-1.68 branch May 17, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants