-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build-configs: rust: disable IBT/Retpoline/Rethunk for the moment #1580
Conversation
Until we have the needed pieces in place in `rustc` and the kernel to support IBT/Retpoline/Rethunk; disable the relevant configs for the moment. This avoids the 2000+ warnings from `objtool` that we currently generate in the logs. Link: https://storage.kernelci.org/mainline/master/v6.1-11554-g785d21ba2f44/x86_64/x86_64_defconfig+rust/rustc-1.62/logs/build-warnings.log Link: Rust-for-Linux/linux#945 Signed-off-by: Miguel Ojeda <[email protected]>
I tested the fragment locally with |
@10ne1 Pinging in case you didn't see it. What should we do to proceed? |
Hi @ojeda Sorry for the delayed response, I'm away from computers / internet due to EoY holidays season, will test this ASAP when I'll be back on 3'rd January. Thanks! |
No rush, Alice may be taking a look too -- Happy New Year! :) |
I've tested this locally and it works with both the mainline and rust-for-linux maintainer trees. I also think this is independent of the docker image bump so is ready to land as is. Thanks!
|
Thanks |
@ojeda just as a suggestion. I just realized that the link file in the comment is on storage.kernelci.org. files on storage.kernelci.org get cleaned after around one month AFAIR, maybe is better to copy the content to gist.github.com and use that link next time. |
Yeah, avoiding ephemeral links sounds better. Thanks for pointing it out! Perhaps I should have just copied a sample inside the Git commit directly. Should it be done only for the links in the commit messages, or also for the ones sometimes are put here in GitHub from staging? i.e. is it only for things that end up in the Git repository? |
@ojeda KernelCI doesn't have a rule about this. that's why it was only a suggestion. In my opinion commit messages as they are lasting more time, is maybe better if they link something a bit more permanent. |
Understood, thanks! |
Until we have the needed pieces in place in
rustc
and the kernel to support IBT/Retpoline/Rethunk (which will take at least a couple months); disable the relevant configs for the moment.This avoids the 2000+ warnings from
objtool
that we currently generate in the logs.Link: https://storage.kernelci.org/mainline/master/v6.1-11554-g785d21ba2f44/x86_64/x86_64_defconfig+rust/rustc-1.62/logs/build-warnings.log
Link: Rust-for-Linux/linux#945
Signed-off-by: Miguel Ojeda [email protected]