Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-configs: rust: disable IBT/Retpoline/Rethunk for the moment #1580

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

ojeda
Copy link
Contributor

@ojeda ojeda commented Dec 17, 2022

Until we have the needed pieces in place in rustc and the kernel to support IBT/Retpoline/Rethunk (which will take at least a couple months); disable the relevant configs for the moment.

This avoids the 2000+ warnings from objtool that we currently generate in the logs.

Link: https://storage.kernelci.org/mainline/master/v6.1-11554-g785d21ba2f44/x86_64/x86_64_defconfig+rust/rustc-1.62/logs/build-warnings.log
Link: Rust-for-Linux/linux#945
Signed-off-by: Miguel Ojeda [email protected]

Until we have the needed pieces in place in `rustc` and the kernel
to support IBT/Retpoline/Rethunk; disable the relevant configs
for the moment.

This avoids the 2000+ warnings from `objtool` that we currently
generate in the logs.

Link: https://storage.kernelci.org/mainline/master/v6.1-11554-g785d21ba2f44/x86_64/x86_64_defconfig+rust/rustc-1.62/logs/build-warnings.log
Link: Rust-for-Linux/linux#945
Signed-off-by: Miguel Ojeda <[email protected]>
@ojeda
Copy link
Contributor Author

ojeda commented Dec 17, 2022

I tested the fragment locally with scripts/kconfig/merge_config.sh, and I see in the config the kselftest fragment using # CONFIG_DUMMY is not set, so I hope this is the right way to disable them in the KernelCI YAML on top of the defconfig!

@ojeda
Copy link
Contributor Author

ojeda commented Dec 22, 2022

@10ne1 Pinging in case you didn't see it. What should we do to proceed?

@aliceinwire aliceinwire self-assigned this Dec 27, 2022
@aliceinwire aliceinwire mentioned this pull request Dec 27, 2022
@10ne1
Copy link
Contributor

10ne1 commented Dec 29, 2022

Hi @ojeda Sorry for the delayed response, I'm away from computers / internet due to EoY holidays season, will test this ASAP when I'll be back on 3'rd January. Thanks!

@ojeda
Copy link
Contributor Author

ojeda commented Dec 29, 2022

No rush, Alice may be taking a look too -- Happy New Year! :)

@aliceinwire
Copy link
Member

yes, I asked @gctucker or @mgalka to enable rustc-1.66 docker image on kernelci for testing. still waiting for a replay.

@10ne1
Copy link
Contributor

10ne1 commented Jan 3, 2023

I've tested this locally and it works with both the mainline and rust-for-linux maintainer trees.

I also think this is independent of the docker image bump so is ready to land as is. Thanks!

Reviewed-by: Adrian Ratiu <[email protected]>

@aliceinwire
Copy link
Member

Thanks

@aliceinwire aliceinwire merged commit 80851e4 into kernelci:main Jan 11, 2023
@aliceinwire
Copy link
Member

@ojeda just as a suggestion. I just realized that the link file in the comment is on storage.kernelci.org. files on storage.kernelci.org get cleaned after around one month AFAIR, maybe is better to copy the content to gist.github.com and use that link next time.

@ojeda ojeda deleted the rust-ibt branch January 11, 2023 10:07
@ojeda
Copy link
Contributor Author

ojeda commented Jan 11, 2023

Yeah, avoiding ephemeral links sounds better. Thanks for pointing it out! Perhaps I should have just copied a sample inside the Git commit directly.

Should it be done only for the links in the commit messages, or also for the ones sometimes are put here in GitHub from staging? i.e. is it only for things that end up in the Git repository?

@aliceinwire
Copy link
Member

@ojeda KernelCI doesn't have a rule about this. that's why it was only a suggestion. In my opinion commit messages as they are lasting more time, is maybe better if they link something a bit more permanent.

@ojeda
Copy link
Contributor Author

ojeda commented Jan 13, 2023

Understood, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants