bpf: tail calls do not modify packet data #10136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 2cbb259 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
87c66e9 to
6f7697d
Compare
Author
|
Upstream branch: 14a7f23 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1017201=>bpf
branch
from
a748822 to
07d99c7
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
6f7697d to
55ff712
Compare
Author
|
Upstream branch: be708ed |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1017201=>bpf
branch
from
07d99c7 to
15015d2
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
55ff712 to
1af0040
Compare
Author
|
Upstream branch: ba36dd5 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1017201=>bpf
branch
from
15015d2 to
a4ce3e2
Compare
Author
|
Upstream branch: ba36dd5 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1017201=>bpf
branch
from
a4ce3e2 to
eff193a
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
1af0040 to
7ea1d98
Compare
Author
|
Upstream branch: 6146a0f |
The bpf verifier checks whether packet data is modified within a helper function, and if so invalidates the pointer to that data. Currently the verifier always invalidates if the helper function called is a tail call, as it cannot tell whether the called function does or does not modify the packet data. However, in this case, the fact that the packet might be modified is irrelevant in the code following the helper call, as the tail call only returns if there is nothing to execute, otherwise the calling (sub)program will return directly after the tail call finished. So it is this (sub)program for which the pointer to packet data needs to be invalidated. Fortunately, there are already two distinct points in the code for invalidating packet pointers directly after a helper call, and for entire (sub)programs. This commit assures that the pointer is only invalidated in the relevant case. Note that this is a regression bug: taking care of tail calls only became necessary when subprograms were introduced, before commit 1a4607f using a packet pointer after a tail call was working fine, as it should. Fixes: 1a4607f ("bpf: consider that tail calls invalidate packet pointers") Signed-off-by: Martin Teichmann <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1017201=>bpf
branch
from
eff193a to
e6c8a38
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
7ea1d98 to
8b55cb4
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1017201 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: tail calls do not modify packet data
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1017201