Merge pull request #169 from keremciu/darkmode-support

Darkmode support
keremciu · Mar 18, 2019 · f978f96 · f978f96
2 parents cf9cf5c + 24b79a1
commit f978f96
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -2,16 +2,16 @@
 [![Latest Version](https://img.shields.io/github/release/keremciu/sketch-iconfont.svg?style=flat-square)](https://github.com/keremciu/sketch-iconfont/releases)
 [![Join the chat at https://gitter.im/keremciu/sketch-iconfont](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/keremciu/sketch-iconfont?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
+### Dark Mode supports - 18 March 2019 (version 4.7.0)
+
+- Adds dark mode support
+
 ### Version 48 supports - 7 December 2017 (Version 4.6.0)
 
 ⚠️ **BEFORE UPDATE**:
 If you're using custom icon fonts, please export your font bundle like this: [VIDEO](http://recordit.co/oxABJWnBeT)
 then update the plugin, you can install the your custom-font-bundle without losing your custom fonts.
 
-Guys, I'm so excited with new updates on Sketch, I will be working on this plugin again to improve your experience! hopefully, we will have a short install process and maybe can add symbol change functionality? mmmh! would be amazing. stay in touch on twitter.
-
-I will share donations here after asking their permissions, it's a motivation thing for me and you, guys. let see what's going on.
-
 ## New version and release video is coming - 19 January 2017
 - I took a video about import custom icons ([VIDEO](http://recordit.co/wy5ihqjPml))
 

diff --git a/iconfont.sketchplugin/Contents/Sketch/add_all.js b/iconfont.sketchplugin/Contents/Sketch/add_all.js
@@ -109,7 +109,7 @@ var onRun = function(context) {
 
   // 6. create a searchbox to filter icons
   var searchbox   = [[NSTextField alloc] initWithFrame:NSMakeRect(200,357,150,24)]
-  searchbox.setBackgroundColor(NSColor.clearColor())
+  searchbox.setBackgroundColor(NSColor.controlBackgroundColor())
   searchbox.setPlaceholderString(@"Search an icon...")
   searchbox.setTarget(self)
   searchbox.setAction("callAction:")

diff --git a/iconfont.sketchplugin/Contents/Sketch/add_grid.js b/iconfont.sketchplugin/Contents/Sketch/add_grid.js
@@ -68,7 +68,7 @@ var onRun = function(context,path,fontname) {
 
   // 6. create a searchbox to filter icons
   var searchbox   = [[NSTextField alloc] initWithFrame:NSMakeRect(200,357,150,24)]
-  searchbox.setBackgroundColor(NSColor.clearColor())
+  searchbox.setBackgroundColor(NSColor.controlBackgroundColor())
   searchbox.setPlaceholderString(@"Search an icon...")
   searchbox.setTarget(self)
   searchbox.setAction("callAction:")

diff --git a/iconfont.sketchplugin/Contents/Sketch/const/library.js b/iconfont.sketchplugin/Contents/Sketch/const/library.js
@@ -408,7 +408,6 @@ var Library = {
       // create a window
       var wrapper = NSWindow.alloc().init()
       [wrapper setFrame:NSMakeRect(0, 0, 600, 420) display:false]
-      wrapper.setBackgroundColor(NSColor.whiteColor())
       wrapper.setTitle(title)
 
       // create a body
@@ -421,7 +420,7 @@ var Library = {
 
       // subtitle in window
       if (subtitle!=nil) {
-        subtitle = Library.Widgets.subtitle(subtitle,22,NSColor.blackColor(),NSMakeRect(25, 355, 300, 30))
+        subtitle = Library.Widgets.subtitle(subtitle,22,NSColor.textColor(),NSMakeRect(25, 355, 300, 30))
         body.addSubview(subtitle)
       }
 

diff --git a/iconfont.sketchplugin/Contents/Sketch/manifest.json b/iconfont.sketchplugin/Contents/Sketch/manifest.json
@@ -76,10 +76,10 @@
     ]
   },
   "identifier" : "com.keremciu.sketch.iconfont",
-  "version" : "4.6.0",
+  "version" : "4.7.0",
   "description" : "Use icons like a boss.",
   "name" : "Icons",
   "authorEmail" : "[email protected]",
-  "compatibleVersion": 48,
+  "compatibleVersion": 50,
   "appcast" : "https://raw.githubusercontent.com/keremciu/sketch-iconfont/master/version.xml"
 }
diff --git a/version.xml b/version.xml
@@ -6,15 +6,15 @@
     <description>Use icons like a boss.</description>
     <language>en</language>
       <item>
-        <title>Version 4.6.0</title>
+        <title>Version 4.7.0</title>
         <description>
           <![CDATA[
             <ul>
-            <li>Fixes for Sketch 48</li>
+            <li>Adds Dark Mode Support</li>
             </ul>
           ]]>
         </description>
-        <enclosure url="https://github.com/keremciu/sketch-iconfont/archive/master.zip" sparkle:version="4.6.0" />
+        <enclosure url="https://github.com/keremciu/sketch-iconfont/archive/master.zip" sparkle:version="4.7.0" />
       </item>
   </channel>
 </rss>