Update Torch and Tensorflow versions in cuda requirements files. #21732
Conversation
Summary of ChangesHello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on synchronizing and upgrading the versions of key deep learning framework dependencies, specifically Torch and TensorFlow, across various environment configurations. The primary goal is to ensure the project benefits from the latest features, performance improvements, and bug fixes provided by these updated library versions, thereby enhancing overall stability and compatibility. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the versions of TensorFlow and PyTorch across various requirement files. The changes are mostly straightforward version bumps. I've identified one potential issue in requirements.txt where the PyTorch dependency for macOS seems to have been accidentally removed. My review includes a suggestion to fix this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21732 +/- ##
==========================================
+ Coverage 77.98% 82.62% +4.64%
==========================================
Files 572 572
Lines 58499 58499
Branches 9143 9143
==========================================
+ Hits 45621 48336 +2715
+ Misses 10657 7838 -2819
- Partials 2221 2325 +104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hertschuh
force-pushed
the
req_version
branch
3 times, most recently
from
ddff6e5 to
3bbf56f
Compare
hertschuh
force-pushed
the
req_version
branch
6 times, most recently
from
e0b1683 to
4a55e58
Compare
hertschuh
force-pushed
the
req_version
branch
11 times, most recently
from
6a4b251 to
e257167
Compare
hertschuh
force-pushed
the
req_version
branch
7 times, most recently
from
0904c7e to
80abe02
Compare
hertschuh
force-pushed
the
req_version
branch
from
80abe02 to
cf8949a
Compare
hertschuh
changed the title
keras/src/export/onnx_test.py
Outdated
| @pytest.mark.skipif( | ||
| testing.tensorflow_uses_gpu(), reason="Leads to core dumps on CI" | ||
| testing.jax_uses_gpu() | ||
| or testing.tensorflow_uses_gpu |
There was a problem hiding this comment.
testing.tensorflow_uses_gpu --> testing.tensorflow_uses_gpu()?
There was a problem hiding this comment.
Oh, good catch. Fixed.
Replacement for keras-team#21704 Also: - Disabled an ONNX export test for Torch that was already disabled on GPU with both JAX and Tensorflow. - Moved install for `tf_keras` from `requirements.txt` to `action.yml` using the `--no-deps` option because `tf_keras` depends on `tensorflow`, which installs the non-CPU version of TensorFlow and causes issues with CPU tests.
hertschuh
force-pushed
the
req_version
branch
from
cf8949a to
778112f
Compare
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
awaiting review
ready to pull
5 participants
Replacement for #21704
Also:
tf_kerasfromrequirements.txttoaction.ymlusing the--no-depsoption becausetf_kerasdepends ontensorflow, which installs the non-CPU version of TensorFlow and causes issues with CPU tests.