-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add save and restore config tests to address TODO items. #18812
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
042fb2c
to
3e25b1f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18812 +/- ##
==========================================
+ Coverage 73.00% 79.21% +6.20%
==========================================
Files 336 336
Lines 34372 34374 +2
Branches 6723 6727 +4
==========================================
+ Hits 25094 27228 +2134
+ Misses 7740 5575 -2165
- Partials 1538 1571 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the PR! Please run |
3e25b1f
to
4be8a3f
Compare
Thank you for the quick reply, @fchollet ! I ran format.sh (which deleted one empty line). Thank you, Nao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
For my first commit to Keras, I picked a simple one, addressing two small TODO items in reduction_metrics_test.py.
I believe what the comment "# TODO: Check save and restore config" meant is that an object (Sum or Mean) must be re-constructed from config, and be tested.
Please let me know if I misunderstood the requirements, or otherwise made any mistakes.