Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save and restore config tests to address TODO items. #18812

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

naoitoi
Copy link
Contributor

@naoitoi naoitoi commented Nov 22, 2023

For my first commit to Keras, I picked a simple one, addressing two small TODO items in reduction_metrics_test.py.

I believe what the comment "# TODO: Check save and restore config" meant is that an object (Sum or Mean) must be re-constructed from config, and be tested.

Please let me know if I misunderstood the requirements, or otherwise made any mistakes.

Copy link

google-cla bot commented Nov 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72cd8be) 73.00% compared to head (4be8a3f) 79.21%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18812      +/-   ##
==========================================
+ Coverage   73.00%   79.21%   +6.20%     
==========================================
  Files         336      336              
  Lines       34372    34374       +2     
  Branches     6723     6727       +4     
==========================================
+ Hits        25094    27228    +2134     
+ Misses       7740     5575    -2165     
- Partials     1538     1571      +33     
Flag Coverage Δ
keras 79.07% <ø> (+6.16%) ⬆️
keras-jax 61.55% <ø> (-0.01%) ⬇️
keras-numpy 56.16% <ø> (-0.01%) ⬇️
keras-tensorflow 63.41% <ø> (?)
keras-torch 64.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fchollet
Copy link
Member

Thanks for the PR! Please run sh shell/format.sh to format the code.

@naoitoi
Copy link
Contributor Author

naoitoi commented Nov 22, 2023

Thanks for the PR! Please run sh shell/format.sh to format the code.

Thank you for the quick reply, @fchollet ! I ran format.sh (which deleted one empty line).
Please LMK if there're more things to fix.

Thank you,

Nao

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 22, 2023
@fchollet fchollet merged commit 344dcde into keras-team:master Nov 22, 2023
6 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants